Conversation
blishko
force-pushed
the
lasolver-less-bookkeeping
branch
from
0d1b0bd to
a66c52e
Compare
Tomaqa
reviewed
Mar 24, 2025
Member
Tomaqa
left a comment
Tomaqa
left a comment
There was a problem hiding this comment.
Looks good! I think we can also format LAVARMapper files, in a separate commit.
| // Must be a new inequality | ||
| assert(tid >= LeqToLABoundRefPair.size() or (LeqToLABoundRefPair[tid] == LABoundRefPair{LABoundRef_Undef, LABoundRef_Undef})); | ||
| if (LeqToLABoundRefPair.size() <= tid) { | ||
| LeqToLABoundRefPair.growTo(tid + 1); |
Member
There was a problem hiding this comment.
I guess we already discussed this: Is it not performance bottleneck?
Member
Author
There was a problem hiding this comment.
It's not for OpenSMT.
I am hitting this in Golem on a few occasions, but I think I can try some workaround on the model checker level.
Note also that we tried using maps in the past (#500), but there was a few percent performance hit for OpenSMT on SMT-LIB benchmarks.
LASolver::updateBound was always called only on new inequalities, never on already seen ones.
blishko
force-pushed
the
lasolver-less-bookkeeping
branch
from
a66c52e to
cbde920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup in LASolver.
Include the removal of method
updateBound.This method was checking if the given bound (PTRef) has already been processed or not.
However, it was only called in a situation where it is guaranteed that the bound has not been seen before (the theory solver keeps track of processed inequalities with
isInformedandsetInformedmethods inLASolver::declareAtom.