Skip to content

Comments

V2.4.4#1682

Open
master3395 wants to merge 4 commits intousmannasir:v2.4.4from
master3395:v2.4.4
Open

V2.4.4#1682
master3395 wants to merge 4 commits intousmannasir:v2.4.4from
master3395:v2.4.4

Conversation

@master3395
Copy link
Collaborator

Fix filemanager download.

…ller

- Updated pluginHolder/urls.py to use path() instead of url()
- Added new API routes for plugin installation, uninstallation, enable, and disable
- Compatible with Django 4.x (url() was removed in Django 4.0)

Ref: PR 1644
…e query parameters

- Changed from incorrect URI splitting to proper request.GET.get() method
- Added proper URL decoding with unquote()
- Fixed both downloadFile and RootDownloadFile functions
- Preserved existing security checks (symlink detection, path traversal prevention)
- Added path normalization for additional security
- Improved error messages to match reported error format

This fixes the 'Unauthorized access: Not a valid file' error when downloading files from the file manager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant