Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces epsilon-greedy sampling to the acquisition function logic, allowing for a mix of random and optimal selection when picking next samples. It also adds input validation for the new parameter and updates plotting marker symbols for improved visualization. The changes are primarily focused on enhancing the sampling strategy and robustness of the acquisition process.
Enhancements to acquisition function sampling:
random_fractionparameter to theAcquisitionFunctionclass and its subclasses, enabling epsilon-greedy sampling where a fraction of samples are chosen randomly from all valid points, and the rest from the top-performing set. [1] [2] [3] [4] [5]get_next_samplesmethod to implement epsilon-greedy sampling logic, including robust error handling for cases with insufficient valid points. [1] [2]Input validation improvements:
random_fractionis within the range [0, 1], raising aValueErrorif out of bounds.Subclass integration:
random_fractionparameter through subclass constructors to ensure consistent behavior across all acquisition function variants. [1] [2] [3] [4]Plotting update:
plot_scatter_plotlyfor clearer and more consistent visualization.