frontend: refactor table styling with modular components#1200
Draft
colton-lapp wants to merge 18 commits intodevfrom
Draft
frontend: refactor table styling with modular components#1200colton-lapp wants to merge 18 commits intodevfrom
colton-lapp wants to merge 18 commits intodevfrom
Conversation
6 tasks
Collaborator
|
This looks great! I think the icons paired with color help with accesibility. The artifact view page is broken for me: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1069
This PR introduces a refactor of the table styling / resource listing views (Plugins, Jobs, Experiments, etc.) to improve improve usability and aesthetics. The primary shift is moving away from ad-hoc table cell implementations toward a system of cell components that can be reused. It also creates a component for a "resource picker" to style some dropdowns in the EditExperiment and CreateEntryPoint pages.
Note that some tables had complex functionalities beyond simple information display and broke out of the "resource listing" pattern - e.g. the EntryPoints page, plugin task tables, etc. These tables could potentially be further modularized / refined.
Notes
tableStyles.jsStill to do:
IconID.vueandBadgeIcon.vueinto a single component. We might also want a subcomponent that simply makes text more emphasized for entity names. Sometimes when referencing the name of resources, I used theResourceName.vuesubcomponent (which adds an underline and a bullet point and implies the text can be clicked).