Add libver bounds argument(s) when opening files#122
Merged
bmaranville merged 12 commits intomainfrom Feb 19, 2026
Merged
Conversation
…r_high to Module.open
Member
Author
|
Note: addresses #119 |
Member
Author
|
I think instead of adding more positional arguments, creating an 'options' argument object like was proposed in #119 is a good idea. It will be a breaking change for anyone that was already using the |
Member
Author
|
I preserved the original File constructor signature, but deprecated it with a JSDoc comment (so TS developers will see it is deprecated). New libver option is only available through using the new |
axelboc
approved these changes
Feb 19, 2026
Collaborator
axelboc
left a comment
There was a problem hiding this comment.
Impressive! Good call on the options object and deprecating the previous constructor signature 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libverbounds supportadded HDF5 library version bounds control to h5wasm, matching h5py's API.
API Changes
File Constructor
libver:"earliest" | "v108" | "v110" | "v112" | "v114" | "v200" | "latest"or[low, high]tupleFile.libver Property
Constants
SWMR fixes
While working on
libverimplementation, also fixed theSWMRwriting implementation. Reading in SWMR mode was already working, but writing was broken.Open for SWMR write: