Return the id and shift of the code with the minimum bit error#21
Open
meyerj wants to merge 1 commit intousrl-uofsc:noetic-develfrom
Open
Return the id and shift of the code with the minimum bit error#21meyerj wants to merge 1 commit intousrl-uofsc:noetic-develfrom
meyerj wants to merge 1 commit intousrl-uofsc:noetic-develfrom
Conversation
…ecoder::decoder()
Contributor
|
If we can get the best available result with no significant penalty in performance I think we should merge. Have you noticed any significant delays? I guess that the size of codewords is not big enough to cause a noticeable delay. |
Contributor
Author
|
We did not evaluate the impact on run-time explicitly. But indeed, for a library with less than 1000 codewords or so it should not matter much compared to the computational cost of finding STag markers in the image in the first place. Maybe for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…from
Decoder::decoder().We did observe some spurious detections of the wrong code, if multiple candidates are sufficiently close, depending on the value of
errorCorrectionpassed to theSTagconstructor. Even for high values it may be desirable to return the candidate with the least amount of bit errors.We are using this patch for a while now in our fork (Intermodalics#1), and the number of false detections has been reduced. What do you think?