Add support for lifecycle.preStop.Sleep and bump dependencies
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lifecycle.preStop.SleepSpecial note:
cache.NewIndexerInformeris deprecatedAbout CRD changes
The CRD has been configured to implement some schema validation. The idea is to reduce the load and complexity of the Admission Controller by shifting left on the validation front. For Example:
A valid
lifecycle.preStophook, only allows for a single option to be specified. This means that we cannot have bothexecandsleepat the same time. This is managed at CRD level making use ofoneOfClick to example of an Incorrect `dcb` - Not all fields are defined for `exec`
When applied:
Click to example of an Incorrect `dcb` - Both `exec` AND `sleep` are specified at the same time
When applied:
The CRD is implementing a check in
lifecycle.preStop.Sleep.secondsto ensure that only positive values are acceptableClick to example of an Incorrect `dcb`
When applied: