ユーザー名検索 #524
Merged
ユーザー名検索 #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aster-void
reviewed
Nov 17, 2024
aster-void
reviewed
Nov 17, 2024
KaichiManabe
reviewed
Dec 2, 2024
Contributor
KaichiManabe
left a comment
KaichiManabe
left a comment
There was a problem hiding this comment.
早めにマージしときたかったので、巻き取っときました！
変更点としては、検索の方法をqueryを使うことで、毎回クリックしなくても済むようにしました！
nakaterm
pushed a commit
that referenced
this pull request
Mar 6, 2025
# PRの概要 検索機能(現在は、ユーザー名のみの部分一致検索) ## 具体的な変更内容 ## 影響範囲 searchタブ内 ## 動作 https://github.com/user-attachments/assets/61db87ab-a4ad-4fea-8b9c-669745bb9713 ## レビューリクエストを出す前にチェック！ - [ ✓] 改めてセルフレビューしたか - [ ✓] 手動での動作検証を行ったか - [ ] server の機能追加ならば、テストを書いたか - 理由: 書いた | server の機能追加ではない - [ ] 間違った使い方が存在するならば、それのドキュメントをコメントで書いたか - 理由: 書いた | 間違った使い方は存在しない - [ ] わかりやすいPRになっているか <!-- レビューリクエスト後は、Slackでもメンションしてお願いすることを推奨します。 --> --------- Co-authored-by: KaichiManabe <[email protected]> Co-authored-by: aster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRの概要
検索機能(現在は、ユーザー名のみの部分一致検索)
具体的な変更内容
影響範囲
searchタブ内
動作
2024-12-02.20.56.09.mov
レビューリクエストを出す前にチェック！