UIdesign v3 #16
Merged
UIdesign v3 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying life-code with
|
| Latest commit: |
371cc24
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95469795.life-code.pages.dev |
| Branch Preview URL: | https://uidesign-v3.life-code.pages.dev |
aster-void
reviewed
Nov 4, 2025
| window.parent.postMessage( | ||
| { | ||
| type: "generation_change", | ||
| data: generationFigure, |
Contributor
There was a problem hiding this comment.
これしようとすると大変になってくるので、外側で世代とかの情報を管理して、「世代交代」だけを iframe に渡すのがいいんじゃないかな。
Contributor
Author
There was a problem hiding this comment.
intervalの間隔は編集可能にしておきたいのでその辺のコードは外に置きたくないってのがあります。
この先似たようなのが増えるわけではない(はず)なので複雑さもそこまでひどくならないとは思いますが...
Contributor
There was a problem hiding this comment.
interval ってこっちで編集機能を用意しておくんじゃなかったっけ？
それならそれでもいいと思う
aster-void
reviewed
Nov 4, 2025
aster-void
reviewed
Nov 4, 2025
src/iframe/life-game.js
Outdated
|
|
||
| on.sizechange = (newSizenum) => { | ||
| const newSize = parseInt(newSizenum, 10); | ||
| if (isNaN(newSize) || newSize < BOARD_MIN || BOARD_MAX < newSize) { |
Contributor
There was a problem hiding this comment.
ここのバリデーション (10以上100以下である) も、外側に移すのが良さそう
Contributor
|
他の作業と範囲被ってるのでいったんマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
・table以外の要素の移設(ボードサイズ、世代表示、リセット、ランダムボタン)
・tableの中央配置
・その他軽微な調整(マスの大きさ、iframe要素の大きさ等)