-
Notifications
You must be signed in to change notification settings - Fork 1
Change RuntimeContext runCommand/runFiles to stream output via callback #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: na-trium-144 <[email protected]>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
my-code | e45bf4b | Commit Preview URL Branch Preview URL |
Jan 05 2026, 06:26 AM |
Co-authored-by: na-trium-144 <[email protected]>
Co-authored-by: na-trium-144 <[email protected]>
|
@copilot compileAndRun()の引数のonOutputはReplOutput型をそのまま扱う必要はありません。引数のonOutputと戻り値の両方でメッセージを出力するのは冗長なので、コールバックによる出力に統一したい。ReplOutput型では情報が不足する(ReplOutputのtypeよりCompilerNdJsonのtypeの方が多い)ので、 |
…ssing Co-authored-by: na-trium-144 <[email protected]>
Changed in commit 4120fae:
The functions no longer accumulate outputs in arrays - they process each output event as it arrives and maintain minimal state to handle multi-line patterns like stack traces. |
Co-authored-by: na-trium-144 <[email protected]>
…ainability Co-authored-by: na-trium-144 <[email protected]>
Co-authored-by: na-trium-144 <[email protected]>
|
@copilot eslintのエラーを修正してください。 app/terminal/tests.ts のテストを修正してください。テストでは出力がリアルタイムに返ってくることはテストする必要はなく、今までの仕様と同様にoutputをarrayなどにまとめて実行が完了してから内容を確認すればよいです。 |
| writeOutput( | ||
| terminalInstanceRef.current, | ||
| outputs, | ||
| true, | ||
| [output], | ||
| false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たぶんこのフラグ変えちゃダメだとおもう
Co-authored-by: na-trium-144 <[email protected]>
... Fixed in commit e45bf4b:
|
RuntimeContext Callback Refactoring - Complete ✅
Successfully refactored RuntimeContext to use callbacks for real-time output streaming.
Final Implementation
Core Changes:
Recent Fixes:
foundSignalvariable in cpp.ts (ESLint error fixed)Wandbox API:
CompileOutputEventtype preserves NDJSON informationQuality Metrics:
Test Updates
All tests have been updated to work with the new callback interface:
Ready for production use.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.