-
Notifications
You must be signed in to change notification settings - Fork 1
m-plus-rounded-1cからhintingを消したものをapp/に書き出して使う #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
my-code | ded3dbf | Commit Preview URL Branch Preview URL |
Jan 06 2026, 03:51 PM |
07670b6 to
30354c6
Compare
30354c6 to
b4012c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes font hinting from the m-plus-rounded-1c font files to fix jagged rendering issues on Windows. The processed fonts are output to the app directory and referenced throughout the application.
- Adds a new build script that removes hinting from m-plus-rounded-1c font files and generates modified WOFF/WOFF2 files with updated CSS
- Moves the copyAllDTSFiles script to the scripts directory and updates its import path
- Updates font family references across the application to use the new "M PLUS Rounded 1c NoHint" font
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/removeHinting.ts | New script to process font files, remove hinting, and generate modified fonts and CSS files |
| scripts/copyAllDTSFiles.ts | Updated import path to reflect the script's new location in the scripts directory |
| package.json | Added removeHinting script to dev/build pipelines and new dependencies (fonteditor-core, pako, @types/pako) |
| package-lock.json | Lock file updates for new dependencies and peer dependency changes |
| app/terminal/terminal.tsx | Updated terminal font family to use "M PLUS Rounded 1c NoHint" |
| app/lib/auth.ts | Updated default font family to prioritize "M PLUS Rounded 1c NoHint" and added more fallback fonts |
| app/layout.tsx | Changed imports from @fontsource packages to local generated CSS files |
| app/globals.css | Updated font family definitions and comments to reflect the use of hint-free fonts |
| .gitignore | Added generated font directory to gitignore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| console.log("To regenerate font files, please delete the directory."); | ||
| } else { | ||
| await woff2.init(); | ||
| await mkdir(outPath); |
Copilot
AI
Jan 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no error handling for the mkdir operation. If the directory creation fails (e.g., due to permission issues), the error will propagate but without a clear error message. Consider wrapping this in a try-catch block with a descriptive error message, or at least checking if the parent directory exists and is writable.
| await mkdir(outPath); | |
| try { | |
| await mkdir(outPath, { recursive: true }); | |
| } catch (error) { | |
| console.error(`Failed to create output directory ${outPath}:`, error); | |
| process.exit(1); | |
| } |
fixes #154