Skip to content

Conversation

@na-trium-144
Copy link
Contributor

@na-trium-144 na-trium-144 commented Jan 6, 2026

  • copyAllDTSFilesをscriptsディレクトリに移動
  • m-plus-rounded-1cからhintingを消したものをpublic/に書き出して使う

fixes #154

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
my-code ded3dbf Commit Preview URL

Branch Preview URL
Jan 06 2026, 03:51 PM

@na-trium-144 na-trium-144 changed the title m-plus-rounded-1cからhintingを消したものをpublic/に書き出して使う m-plus-rounded-1cからhintingを消したものをapp/に書き出して使う Jan 6, 2026
@na-trium-144 na-trium-144 requested a review from Copilot January 6, 2026 13:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes font hinting from the m-plus-rounded-1c font files to fix jagged rendering issues on Windows. The processed fonts are output to the app directory and referenced throughout the application.

  • Adds a new build script that removes hinting from m-plus-rounded-1c font files and generates modified WOFF/WOFF2 files with updated CSS
  • Moves the copyAllDTSFiles script to the scripts directory and updates its import path
  • Updates font family references across the application to use the new "M PLUS Rounded 1c NoHint" font

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
scripts/removeHinting.ts New script to process font files, remove hinting, and generate modified fonts and CSS files
scripts/copyAllDTSFiles.ts Updated import path to reflect the script's new location in the scripts directory
package.json Added removeHinting script to dev/build pipelines and new dependencies (fonteditor-core, pako, @types/pako)
package-lock.json Lock file updates for new dependencies and peer dependency changes
app/terminal/terminal.tsx Updated terminal font family to use "M PLUS Rounded 1c NoHint"
app/lib/auth.ts Updated default font family to prioritize "M PLUS Rounded 1c NoHint" and added more fallback fonts
app/layout.tsx Changed imports from @fontsource packages to local generated CSS files
app/globals.css Updated font family definitions and comments to reflect the use of hint-free fonts
.gitignore Added generated font directory to gitignore

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

console.log("To regenerate font files, please delete the directory.");
} else {
await woff2.init();
await mkdir(outPath);
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no error handling for the mkdir operation. If the directory creation fails (e.g., due to permission issues), the error will propagate but without a clear error message. Consider wrapping this in a try-catch block with a descriptive error message, or at least checking if the parent directory exists and is writable.

Suggested change
await mkdir(outPath);
try {
await mkdir(outPath, { recursive: true });
} catch (error) {
console.error(`Failed to create output directory ${outPath}:`, error);
process.exit(1);
}

Copilot uses AI. Check for mistakes.
@na-trium-144 na-trium-144 merged commit aec0763 into main Jan 6, 2026
3 checks passed
@na-trium-144 na-trium-144 deleted the remove-hinting-mplus branch January 6, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

低解像度のWindowsChromeでRoundedM+の見栄えが悪い

2 participants