Feat/personalization #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aster-void
reviewed
Sep 9, 2025
| interface Props { | ||
| selectedChannelId?: Id<"channels">; | ||
| screenMode: string; |
Contributor
There was a problem hiding this comment.
selectedChannelId と screenMode は
screenMode = "channel" -> selectedChannelId は必須
screenMode = "personalization" -> selectedChannelId は不要
という関係にあるので、その関連性を反映した型にするといいね
type Selection =
| {
type: "chat";
channelId: Id<"channels">;
| {
type: "personalization";
};
aster-void
reviewed
Sep 9, 2025
| import Personalization from "./Personalization.svelte"; | ||
| let selectedChannelId = $state<Id<"channels"> | undefined>(undefined); | ||
| let screenMode = $state("chat"); |
Contributor
There was a problem hiding this comment.
これは、文字列ならなんでもとれるわけではなく、 "chat" か "personalization" の二択だと思うので、それを反映した型をつけるといいね
let screenMode = $state<"chat" | "personalization">("chat");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.