Modify internal heat from compo conductance#44
Open
Hideki-1029 wants to merge 12 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Mention any issues that this pull request is related (e.g., #1). Consider using the
developmentfield if you want to close the issue automatically when this pull request is merged.Description
コンポの内部発熱を模擬するロジックおよびyaml(component_properties.yaml)を構築。
component_properties.yamlの"internal_heat"に内部発熱を書き込めばよい。
変更点の詳細はdoc/internal_heat_changes.mdに記載。
動作確認として、熱的に孤立させたBAT2を設定(BATと繋がってはいるが熱コンダクタンス0)し、以下の設定の下で動作させたところ
component_properties:
BAT2:
name: "Battery2"
mass: 2.1
specific_heat: 700.0
internal_heat: 3.0 # ← 追加 (W)
mounting:
target: "BAT"
thermal_conductance: 0.0
BAT2の温度履歴は写真のようになった。
設定上だと、
C = 1470 J/KdT/dt = 3 / 1470 ≈ 0.00204 K/sとなり、温度履歴と整合性が取れていることがわかった。
Test results
Provide the test results and a link to the detailed results log.
Impact
Describe the scope of influence of the changes, e.g.,
The behavior of feature ** changes.Supplementary information
Provide any supplementary information.
Notes
Assignees.Reviewersfor this pull request.prioritylabel.