Open
Conversation
mshinjo
force-pushed
the
finch-development-flag
branch
from
3795dcb to
0612559
Compare
mshinjo
requested review from
TheArchons,
alexapostolu,
chopikus,
coby1kenobi and
swarnavaghosh04
as code owners
Member
|
It might be better to have separate debug Kconfigs for debug instead of one main debug config, thoughts? |
TheArchons
reviewed
Mar 10, 2026
mshinjo
force-pushed
the
finch-development-flag
branch
from
0612559 to
e7b5af7
Compare
Member
Author
Yeah, I didn't actually mean 'debug', but I mentioned it... Removed it where mentioned. The |
Add a 'FINCH_DEVELOPMENT' Kconfig option so development configuration can stay separate from flight-ready builds. This is important because: 1. We want to be able to switch between the two easily (a single Kconfig option is nice and easy). 2. We want to avoid ad-hoc comment out/in styles, which is very messy (including commenting out/in Kconfig options). 3. We want to make sure we can run CI on both modes. Signed-off-by: Mirai SHINJO <oss@mshinjo.com>
Move GPIO and serial defaults into the FINCH board defconfigs so these hardware-dependent capabilities live under 'boards/' instead of being repeated in the apps' prj.conf files. Signed-off-by: Mirai SHINJO <oss@mshinjo.com>
This keeps the default builds flight-ready and lets development builds opt in through the FINCH_DEVELOPMENT Kconfig. Signed-off-by: Mirai SHINJO <oss@mshinjo.com>
Disable the Zephyr boot banner and printk in the default app configurations so the default flight builds stay quiet on UART. Development builds can still enable UART logging through 'FINCH_DEVELOPMENT'. Signed-off-by: Mirai SHINJO <oss@mshinjo.com>
mshinjo
force-pushed
the
finch-development-flag
branch
from
e7b5af7 to
fdb3d9f
Compare
|
|
||
| CONFIG_LOG=y | ||
| CONFIG_LOG_DEFAULT_LEVEL=3 | ||
| CONFIG_BOOT_BANNER=n |
Member
There was a problem hiding this comment.
If I create a really nice ASIC art FINCH boot banner, then can we enable the boot banner :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to have a clean mechanism to switch between development
builds and flight-ready builds without relying on ad-hoc comment/uncomment
changes in app configs.
Also, this separates hardware-dependent configuration from the app layer.