feat: initial amd gpu support with rocm 7.1#28
Closed
pyqlsa wants to merge 2 commits intoutensils:mainfrom
Closed
Conversation
jamesbrink
added a commit
that referenced
this pull request
Feb 20, 2026
Cherry-picked pyqlsa's ROCm implementation (commits 7e6f796, e2343fe) and applied fixes on top: - Fix ROCm app incorrectly named "cuda" in nix/apps.nix (would shadow CUDA) - Fix mkPython passing boolean `false` instead of string `"none"` for gpuSupport - Fix flake description still referencing v0.12.2 instead of v0.14.2 - Fix README Podman ROCm example referencing latest-cuda instead of latest-rocm - Fix ROCm torchaudio missing FFmpeg/sox ignore deps (matching CUDA pattern) - Resolve all TODO/XXX review comments left by pyqlsa - Update CHANGELOG, CLAUDE.md, and README with ROCm documentation - Fix CHANGELOG footer links (missing v0.14.2 link, Unreleased pointing to v0.12.2) Closes #27 Co-authored-by: pyqlsa <26353308+pyqlsa@users.noreply.github.com>
5 tasks
Member
jamesbrink
added a commit
that referenced
this pull request
Feb 20, 2026
* feat: initial amd gpu support with rocm 7.1 * formatting * fix: resolve bugs and clean up ROCm support from PR #28 Cherry-picked pyqlsa's ROCm implementation (commits 7e6f796, e2343fe) and applied fixes on top: - Fix ROCm app incorrectly named "cuda" in nix/apps.nix (would shadow CUDA) - Fix mkPython passing boolean `false` instead of string `"none"` for gpuSupport - Fix flake description still referencing v0.12.2 instead of v0.14.2 - Fix README Podman ROCm example referencing latest-cuda instead of latest-rocm - Fix ROCm torchaudio missing FFmpeg/sox ignore deps (matching CUDA pattern) - Resolve all TODO/XXX review comments left by pyqlsa - Update CHANGELOG, CLAUDE.md, and README with ROCm documentation - Fix CHANGELOG footer links (missing v0.14.2 link, Unreleased pointing to v0.12.2) Closes #27 Co-authored-by: pyqlsa <26353308+pyqlsa@users.noreply.github.com> --------- Co-authored-by: pyqlsa <26353308+pyqlsa@users.noreply.github.com>
Member
Contributor
Author
|
No worries at all. I'm back to the keyboard and will check this all out. Thank you @jamesbrink ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intended to address #27 by adding ROCm support for AMD GPUs.
Adds
gfx1100with a 7900XTX, and a couple of the default text-to-image and image-to-image template workflows appear to be working as one would expect; there are a few gotchas with ROCm support in general (e.g.xformers), but there look to be known workarounds with tunables nominally available with ComfyUI; CPU architecture compat is only x86_64.nix run .#rocm; (testedgfx1100with a 7900XTX); CPU architecture compat is only x86_64.nix build .#dockerImageROCm; (testedgfx1100with a 7900XTX running with podman); running with docker not yet tested). CPU architecture compat is only x86_64.rocmvariant (tested on my own system configuration).Changes
cudaSupporttoggle to agpuSupportenum; users (and internal plumbing) now select betweencuda,rocm, andnone(for cpu-only).Observations/Comments
autoPatchelfIgnoreMissingDepsanything for sox or ffmpeg; I'm not quite sure why that was required for CUDA and not for ROCm.rocminfoon launch, and I can't figure out yet what it is; I tried adding it asbuildInputandpropogatedBuildInputin torch, and in the comfyui derivation, but nothing seemed to stick; even without it, ComfyUI starts just fine, but writes some warnings to the logs that it couldn't findrocminfo, but it was able to detect ROCm and GPUs anyways; I threwrocminfointo the container and the systemd unit path to make those warnings go away, regardless.test_optimtest fortimm, to I tried just huckingsetuptoolsin there, and it seemed to work; based on the surrounding comment and ignoringtimm'stest_krontest, I'm not sure if my choice is an anti-pattern or not.TODOandXXXcomments in there that overlap with some of these thoughts; I'm happy to clean those up before a potential merge, but they're in there for now in case they prompt any specific feedback.