Update llama.cpp dependency to the latest version; Fix all clippy lints.#622
Merged
MarcusDunn merged 2 commits intoutilityai:mainfrom Jan 22, 2025
Merged
Update llama.cpp dependency to the latest version; Fix all clippy lints.#622MarcusDunn merged 2 commits intoutilityai:mainfrom
MarcusDunn merged 2 commits intoutilityai:mainfrom
Conversation
Contributor
|
This is great! Thanks for the PR! |
MarcusDunn
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the llama.cpp dependency to latest as of today in order to run the new Deepseek R1 models with this library. I also fixed all clippy lints while I was at it, because it annoyed me that they exist.
The only break to the user-facing API is that
LlamaSampler::penalties_simplehas been removed, andLlamaSampler::penaltieshas had a number of parameters removed, because these parameters were removed upstream in llama.cpp. Let me know if you want to see any changes!