Skip to content

more reliable target directory estimation#638

Merged
MarcusDunn merged 1 commit intoutilityai:mainfrom
ISAWarden:fix/improved-target-directory-estimation
Feb 7, 2025
Merged

more reliable target directory estimation#638
MarcusDunn merged 1 commit intoutilityai:mainfrom
ISAWarden:fix/improved-target-directory-estimation

Conversation

@peterwilli
Copy link
Copy Markdown
Contributor

Currently, llama-cpp-rs fails with "not found" when compiling a project using a different profile.

For example, having this in our cargo toml:

[profile.dist]
lto = true
inherits = "release"
codegen-units = 1
panic = "abort"
strip = "debuginfo"

[profile.release]
opt-level = 3

Then compile like this: cargo build --profile=dist will fail because PROFILE is always "release"

The new way just goes back 3 steps which will always be the target (source: https://stackoverflow.com/a/73603419).

@MarcusDunn MarcusDunn merged commit dec1651 into utilityai:main Feb 7, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants