Explicitly apply optimization flags to msvc compiler also on other profiles than debug#682
Merged
MarcusDunn merged 1 commit intoutilityai:mainfrom Feb 25, 2025
Conversation
…ofiles than debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all because of a bug in cmake-rs.
See #649 for discussion.
This reduced conditional was actually written by @babichjacob (see comment)
Before this PR, release builds for x86_64-pc-windows-msvc were significantly slower than debug builds.
With this PR, release profile builds also get the optimization flags passed into msvc explicitly.
This workaround may no longer be necessary if the relevant fixes get applied to cmake-rs.