Conversation
|
seems there are conflicts. Will merge once done. Thanks for the PR! |
|
sorry about that, stale fork.. |
|
Hold on - what does this actually solve? We have been deploying to ios and simulators for months already, without this PR. |
|
@AsbjornOlling good for you. i had trouble deploying in both case (sim and real). definitely the 1 liner could be included for the platform check when to auto-add metal feature. |
|
@vigsterkr I'm not trying to place mistrust that it solves actual problems for you. It's just that I'd like to hear more details about what error you encountered, and how this solves it - so I can learn. I completely agree that adding the metal feature by default is a good idea. But I do think that the title for this PR is a bit off (NobodyWho is already shipping iOS binaries based on this crate), and that adding a description to this PR with some details about what problems this PR solves is warranted. It can really help figure out why code exists when debugging problems in the future 😇 |
3 participants
No description provided.