Skip to content

Fix export notes stuck on v60+ #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix export notes stuck on v60+ #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c85597
Merge pull request #1 from utom/master
forestlin1212 Nov 29, 2018
9533093
1.fix for issue #505, #511, note can't be exported.
Nov 29, 2018
264a920
only export 1x images
forestlin1212 Jan 9, 2019
2814b49
Merge remote-tracking branch 'utom/master'
forestlin1212 Jan 27, 2020
ef41ad2
Merge remote-tracking branch 'origin/master'
forestlin1212 Jan 27, 2020
eadbc34
Fixed the issue of getting stuck when exporting notes on v60+.
forestlin1212 Jan 27, 2020
be34963
Merge branch 'fix-notes-stuck'
forestlin1212 Jan 27, 2020
6230f03
back to utom version
forestlin1212 Jan 27, 2020
f06b98d
Fixed the issue of getting stuck when exporting notes on v60+
forestlin1212 Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions Sketch Measure.sketchplugin/Contents/Sketch/library/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3107,13 +3107,18 @@ SM.extend({
layerStates = this.getStates(layer);

if(layer && this.is(layer, MSLayerGroup) && /NOTE\#/.exec(layer.name())){
var textLayer = layer.children()[2];

data.notes.push({
rect: this.rectToJSON(textLayer.absoluteRect(), artboardRect),
note: this.toHTMLEncode(this.emojiToEntities(textLayer.stringValue())).replace(/\n/g, "<br>")
});
layer.setIsVisible(false);
//fix the note stuck issue on Sketch 60+
for(let i=0; i<layer.containedLayersCount(); i++){
childLayer = layer.layerAtIndex(i);
if (this.is(childLayer, MSTextLayer)) {
data.notes.push({
rect: this.rectToJSON(childLayer.absoluteRect(), artboardRect),
note: this.toHTMLEncode(this.emojiToEntities(childLayer.stringValue())).replace(/\n/g, "<br>")
});
layer.setIsVisible(false);
break;
}
}
}

if (
Expand Down
2 changes: 1 addition & 1 deletion appcast.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<description>
<![CDATA[
<ul>
<li>Support Sketch v52</li>
<li>Support Sketch v62</li>
</ul>
]]>
</description>
Expand Down