feat(turbopack): chunkingContext support chunkLoadingGlobal #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xusd320
reviewed
Jan 20, 2026
| //`x || (x = default)` is better than `x = x || default` simply because we avoid _writing_ the property in the common case. | ||
| r#" | ||
| (globalThis.TURBOPACK || (globalThis.TURBOPACK = [])).push([ | ||
| (globalThis.{chunk_loading_global} || (globalThis.{chunk_loading_global} = [])).push([ |
There was a problem hiding this comment.
这样就别用 globalThis. 了 , 如果 chunk_loading_global 是 a.b 就挂了
fireairforce
changed the title
fireairforce
force-pushed
the
support-chunk-loading-global
branch
from
9edcb49 to
3cb017d
Compare
xusd320
reviewed
Jan 20, 2026
| // `||=` would be better but we need to be es2020 compatible | ||
| //`x || (x = default)` is better than `x = x || default` simply because we avoid _writing_ the property in the common case. | ||
| "(globalThis.TURBOPACK || (globalThis.TURBOPACK = [])).push([{script_or_path}," | ||
| "(globalThis[\"{chunk_loading_global}\"] || (globalThis[\"{chunk_loading_global}\"] = \ |
xusd320
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utoopack issue: utooland/utoo#2526
Turbopack 提供一个
chunk_loading_global的方法挂在 BrowserChunkingContextBuilder 上，在 turbopack 这一侧默认保持使用globalThis.TURBOPACK，utoopack 可以通过调用这个方法来定义 utoopack 需要的 global variables。这个改动不影响 Turbopack 本身的逻辑，这个配置目前只会影响以下两个 global variables: