fix(turbopack): alias resolve lost query param

[fireairforce]

User code:

import styles from '@/index.less';

styles;

alias config:

alias: {
  '@/*': './intput/*'
}

Before:

import style from '@/index.less'
    ↓ (transform add `?modules`)
'@/index.less?modules'
    ↓ (alias resolve，query lost)
'./input/index.less'  ← without query `?modules`, lightningcss doesn't deal css as css modules
    ↓
style = void 0  ❌

After:

import style from '@/index.less'
    ↓ (transform add `?modules`)
'@/index.less?modules'
    ↓ (alias resolve，query keep)
'./input/index.less?modules'  ← `?modules` keep
    ↓
style = { nav: "index-less__xxx__nav" }  ✅

[gemini-code-assist]

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in Turbopack's alias resolution logic. Previously, any query parameters appended to an import request were inadvertently dropped when an alias was applied. This behavior prevented modules that rely on these parameters, such as CSS modules using ?modules, from being correctly processed. The change ensures that query parameters are now consistently retained throughout the alias resolution process, leading to correct module interpretation and functionality.

Highlights

• Alias Resolution: Fixed an issue where query parameters (e.g., ?modules) were lost during alias resolution, ensuring they are now correctly preserved.
• CSS Modules Support: This fix specifically addresses a problem where CSS modules were not being processed correctly due to the loss of the ?modules query parameter during alias resolution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where query parameters were being dropped during alias resolution in Turbopack. The fix involves preserving the query string from the original import and applying it to the request generated from the alias. This is a good, targeted fix for the described problem, especially important for features like CSS modules which rely on query parameters. The implementation is clear, idiomatic, and appears correct.

[xusd320]

May post to upstream.

[fireairforce]

May post to upstream.

yes, i am writing test case now