-
Notifications
You must be signed in to change notification settings - Fork 0
feat(turbo-tasks-fs): enable fs watcher on wasm #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the turbo-tasks-fs crate by introducing robust file system watching capabilities for WebAssembly environments. This enables applications running in browser-like contexts to efficiently monitor and react to changes in the file system, which is crucial for dynamic content and development workflows.
Highlights
- WASM File System Watcher Enabled: The core functionality of file system watching has been extended and enabled for WebAssembly (WASM) targets within the
turbo-tasks-fscrate, allowing real-time file system event monitoring in WASM environments. - Dependency Updates and Refactoring: Key dependencies such as
tokio-fs-extwere updated to version0.6.0with new features (opfs_offload,opfs_watch), andnotify-typeswas introduced to provide a unified event handling mechanism across different platforms. - Platform-Specific Implementations: The
watchermodule is now universally available, with distinct implementations for native and WASM environments. The WASM implementation leverageswasm_fs_offload::CLIENT.watch_dirto process file system events and invalidate caches. - Asynchronous Operations for WASM: File system operations and watcher initialization for WASM targets are now asynchronous, aligning with the nature of browser-based file system interactions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
c887930 to
0e05ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables the filesystem watcher on wasm targets. The changes involve updating dependencies and using conditional compilation to provide a wasm-specific watcher implementation. I've found a few critical issues that will prevent the feature from working correctly or break existing functionality on other platforms. There are also some medium-severity issues related to code clarity and maintainability.
ce841f2 to
7ee281b
Compare
7ee281b to
3a9e273
Compare
RT.