Skip to content

Conversation

@xusd320
Copy link

@xusd320 xusd320 commented Sep 2, 2025

RT.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the turbo-tasks-fs crate by introducing robust file system watching capabilities for WebAssembly environments. This enables applications running in browser-like contexts to efficiently monitor and react to changes in the file system, which is crucial for dynamic content and development workflows.

Highlights

  • WASM File System Watcher Enabled: The core functionality of file system watching has been extended and enabled for WebAssembly (WASM) targets within the turbo-tasks-fs crate, allowing real-time file system event monitoring in WASM environments.
  • Dependency Updates and Refactoring: Key dependencies such as tokio-fs-ext were updated to version 0.6.0 with new features (opfs_offload, opfs_watch), and notify-types was introduced to provide a unified event handling mechanism across different platforms.
  • Platform-Specific Implementations: The watcher module is now universally available, with distinct implementations for native and WASM environments. The WASM implementation leverages wasm_fs_offload::CLIENT.watch_dir to process file system events and invalidate caches.
  • Asynchronous Operations for WASM: File system operations and watcher initialization for WASM targets are now asynchronous, aligning with the nature of browser-based file system interactions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the filesystem watcher on wasm targets. The changes involve updating dependencies and using conditional compilation to provide a wasm-specific watcher implementation. I've found a few critical issues that will prevent the feature from working correctly or break existing functionality on other platforms. There are also some medium-severity issues related to code clarity and maintainability.

@xusd320 xusd320 force-pushed the feat/wasm-fs-watch branch 2 times, most recently from ce841f2 to 7ee281b Compare September 2, 2025 11:33
@xusd320 xusd320 merged commit 3d8c303 into utoo-wasm Sep 2, 2025
14 of 27 checks passed
@xusd320 xusd320 deleted the feat/wasm-fs-watch branch November 25, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants