-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ruleCondition support query condition #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
此拉取请求引入了一项新功能,允许模块规则条件根据资源的查询字符串进行匹配。这增强了规则条件的灵活性,使其能够更细致地控制模块的匹配行为。
Highlights
- 新增规则条件: 在
RuleCondition枚举中新增了ResourceQueryContains变体,允许根据资源的查询字符串进行匹配。 - 查询条件匹配逻辑: 为
ResourceQueryContains实现了applies_to方法,使其能够检查资源的标识符查询部分是否包含指定的字符串。
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这个 PR 旨在为 RuleCondition 添加对资源 query 的匹配支持,这是一个很棒的功能。代码实现上有一个小问题:在 matches 函数中,ident.query 是一个 Vc<String> 类型,需要先 await 才能获得其字符串值并调用 contains 方法。我已经提出了具体的修改建议。另外,PR 的标题中有一个小拼写错误:“querry” 应该是 “query”。
turbopack/crates/turbopack/src/module_options/rule_condition.rs
Outdated
Show resolved
Hide resolved
8acc04e to
b80af4d
Compare
b80af4d to
0128afc
Compare
|
没有对应配置项吗?怎么控制 query condition 是否生效? |
turbopack 目前没有 resourcequery 配置,loader 那个也还不支持,这个 query 是我通过 transform 添加的: vercel#79311 (comment) |
module 的 rule condition 能支持匹配带 query 的语句,举个例子,去 match 这样的 query 代码:
rust 侧的代码匹配: