Skip to content

fix(turbopack-css): ignore lightning-css global pseudo elements warning#65

Merged
fireairforce merged 2 commits intoutoofrom
fix-turbopack-css-selector-warning
Oct 28, 2025
Merged

fix(turbopack-css): ignore lightning-css global pseudo elements warning#65
fireairforce merged 2 commits intoutoofrom
fix-turbopack-css-selector-warning

Conversation

@fireairforce
Copy link
Member

for issue: utooland/utoo#2269

先暂时把 :global {} 以及 :global() 中的伪元素场景忽略掉,这里先做最小改动,后续遇到了更多的 unsupported 伪类元素再看情况处理。

@fireairforce fireairforce changed the title fix(css): ignore lightning-css global pseudo elements warning fix(turbopack-css): ignore lightning-css global pseudo elements warning Oct 28, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the lightning-css parser was incorrectly flagging :global pseudo-classes as unsupported, leading to unnecessary warnings during CSS processing. The change introduces a precise mechanism to suppress these specific warnings, ensuring that CSS from preprocessors like LESS can be processed without generating irrelevant alerts, thereby improving the clarity of the build output.

Highlights

  • CSS Warning Suppression: Added specific logic to ignore warnings generated by lightning-css when it encounters the :global pseudo-class, which is often used by CSS preprocessors.
  • Targeted Fix: This change provides a minimal, targeted fix to address the immediate issue of :global pseudo-element warnings, with a plan to evaluate broader unsupported pseudo-element handling in the future.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献!这个修复看起来是正确的,它通过忽略 lightningcss 产生的关于 :global 伪元素的警告,解决了问题。

我有一个关于代码风格和可读性的建议:可以将 if let 检查合并到 match 语句中,使错误处理逻辑更加集中和清晰。详细信息请看我的具体评论。

除此之外,代码改动很直接,解决了目标问题。

@fireairforce fireairforce merged commit 5ca68b4 into utoo Oct 28, 2025
14 of 27 checks passed
@xusd320 xusd320 deleted the fix-turbopack-css-selector-warning branch November 25, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants