Skip to content

Conversation

@fireairforce
Copy link

https://github.com/swc-project/swc/blob/main/crates/swc_ecma_lints/src/rules/critical_rules.rs#L770

把这个 error 先放宽成 warn,webpack 对这种 case 不会检查。

@fireairforce fireairforce merged commit b071a36 into utoo Nov 6, 2025
12 of 22 checks passed
@gemini-code-assist
Copy link

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines how Turbopack processes certain code constructs by reclassifying specific issues. It modifies the system to treat instances of duplicate variable declarations as warnings rather than critical errors. This change is intended to enhance compatibility with existing codebases and development workflows, particularly those that might be less strict about such declarations.

Highlights

  • Error Severity Downgrade: The severity of 'duplicate binding' errors has been downgraded from Error to Warning within the Turbopack SWC utility emitter. This change specifically targets messages containing 'defined multiple times'.
  • Compatibility Improvement: This adjustment aims to align Turbopack's behavior with Webpack, which does not treat duplicate binding cases as errors, thus potentially reducing build failures for compatible code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献。这个修改将 SWC 的重复绑定错误降级为警告,以与 Webpack 的行为保持一致。代码实现是直接的,但我发现了一些可以改进的地方以提高代码质量:

  1. match 语句中存在编译错误和重复的代码块,可以进行重构以提高可读性和可维护性。
  2. 用于检测重复绑定错误的字符串是一个“魔法字符串”,最好将其提取为常量。

我在代码中留下了具体的建议。请查看。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants