fix(turbopack): downgrade duplicate binding from error to warn#70
fix(turbopack): downgrade duplicate binding from error to warn#70fireairforce merged 1 commit intoutoofrom
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines how Turbopack processes certain code constructs by reclassifying specific issues. It modifies the system to treat instances of duplicate variable declarations as warnings rather than critical errors. This change is intended to enhance compatibility with existing codebases and development workflows, particularly those that might be less strict about such declarations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
https://github.com/swc-project/swc/blob/main/crates/swc_ecma_lints/src/rules/critical_rules.rs#L770
把这个 error 先放宽成 warn,webpack 对这种 case 不会检查。