Skip to content

Conversation

@xusd320
Copy link

@xusd320 xusd320 commented Dec 3, 2025

Loader's worker should run with an async loop forever, or else, it run only once.

@xusd320 xusd320 requested a review from fireairforce December 3, 2025 11:55
@xusd320 xusd320 changed the title feat(turbopack): apply utoo patches to canary fix(turbopack-node): async loop running in loaders worker thread Dec 3, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in Turbopack where loader workers would terminate after a single execution. By refactoring the worker evaluation mechanism and introducing a dedicated TaskChannel for IPC, the changes ensure that workers operate in a persistent, asynchronous loop, significantly improving the stability and continuous processing capabilities of Turbopack's build system.

Highlights

  • Worker Persistence Fix: The primary change ensures Turbopack's loader workers run in a continuous asynchronous loop, resolving an issue where they would only execute once.
  • IPC Refactoring: Introduces a new TaskChannel class to centralize and streamline inter-process communication (IPC) logic within worker threads.
  • Dependency Update: The Cargo.toml for turbopack-tests is updated to explicitly manage features for turbopack-node, enabling the process_pool feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xusd320 xusd320 closed this Dec 3, 2025
@xusd320 xusd320 reopened this Dec 3, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where the loader's worker thread only runs once, by introducing an async loop. The refactoring of IPC logic into a TaskChannel class is a good improvement for code clarity and reusability.

However, I've found a critical issue in the new implementation of the worker loop in both web_worker/evaluate.ts and worker_threads/evaluate.ts. The current logic is likely to cause deadlocks when a worker task needs to communicate back to the main process, as it tries to acquire a new task before the current one is finished with all its communications. I've left detailed comments on the respective files.

@xusd320 xusd320 merged commit 74386ba into utoo Dec 3, 2025
14 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants