fix(turbopack-core): fs root output name

[xusd320]

Repalce undesirable characters like [, ], <, > with _.

[gemini-code-assist]

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logic for sanitizing file system output names within turbopack-core. By broadening the range of characters that are replaced with underscores and streamlining the handling of specific root path markers, the changes aim to produce more consistent and robust file names, preventing potential issues caused by special characters in generated output paths.

Highlights

• Character Sanitization: Expanded the set of undesirable characters replaced by underscores in file system output names to include [, ], <, and >.
• Path Root Handling: Removed the specific replacement of [root-of-the-server] in output names, simplifying the clean_additional_extensions function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to sanitize asset identifiers by replacing more undesirable characters. The change to the regex in clean_separators correctly adds [, ], <, and > to the list of characters replaced by an underscore. However, there's a potentially unintended side-effect in clean_additional_extensions. The removal of the explicit replacement for [root-of-the-server] changes its handling from complete removal to being transformed into _root-of-the-server_. I've added a comment to clarify if this is the intended behavior and suggested restoring the original logic if it was an oversight.