Skip to content

Conversation

@fireairforce
Copy link

清理重复的 clean_separators 方法,目前 turbopack 里面没地方消费 turbopack-browser 里面的这个方法

@gemini-code-assist
Copy link

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code cleanup and consolidation by addressing a redundant utility function. It removes an unused clean_separators function from the turbopack-browser crate and promotes the existing clean_separators function in turbopack-core to public visibility. This change ensures a single, authoritative implementation for cleaning separators, improving maintainability and consistency within the Turbopack project.

Highlights

  • Code Redundancy Removal: The clean_separators function, which was duplicated and unused within the turbopack-browser crate, has been completely removed to streamline the codebase.
  • Function Visibility Update: The clean_separators function in the turbopack-core crate has been updated from a private to a public function, making it accessible for broader use across the project as the canonical implementation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@fireairforce fireairforce force-pushed the remove-clean-separators branch from 2cd3055 to 319dcec Compare December 26, 2025 06:26
@fireairforce fireairforce merged commit da96ced into utoo Dec 26, 2025
11 of 24 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 通过移除 turbopack-browser 中一个重复的 clean_separators 函数并公开 turbopack-core 中的版本,来整理代码库。这是一个很好的重构,有助于统一功能实现。

需要注意的是,被移除的函数和保留的函数在实现上存在差异:

  • 被移除的函数 (turbopack-browser):删除字符 /#?@
  • 保留的函数 (turbopack-core):将 /#?[]<>@ 替换为 _

根据 PR 的描述,被移除的函数没有被使用,所以这个改动应该是安全的。将这个逻辑集中到 turbopack-core 中是合理的做法。

I am having trouble creating individual review comments. Click here to see my feedback.

turbopack/crates/turbopack-browser/src/chunking_context.rs (947-950)

medium

这个函数的功能与 turbopack-core 中的 clean_separators 函数并不完全相同。此函数移除 /#?@ 字符,而 turbopack-core 中的版本则将更广泛的字符集 (/#?[]<>@) 替换为下划线 _。虽然根据描述此函数已不再使用,但将两者称为“重复”可能会产生误导。在提交信息或代码注释中准确描述这种差异,有助于提高代码的可维护性。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants