-
Notifications
You must be signed in to change notification settings - Fork 0
perf(turbopack): use trace_span in tracing::instrument #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a performance optimization for Turbopack by adjusting the default verbosity of its internal tracing. It systematically changes the tracing level of many Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant performance improvement by changing the logging level of numerous tracing spans from info to trace. This change is applied consistently across a wide range of files in Turbopack, which will help reduce tracing overhead in production environments. The changes are extensive and cover areas like NAPI endpoints, project lifecycle, module graph operations, and low-level filesystem and task management functionalities.
I've reviewed the changes and they appear to be correct and well-executed. The mechanical nature of the change (replacing info_span! with trace_span! and level = "info" with level = "trace") is consistent throughout the PR.
A minor stylistic change from tracing::Level::TRACE to "trace" was also noted in some files, which seems to be for consistency.
Overall, this is a great contribution to improving Turbopack's performance.
P.S. There's a small typo in the PR description: 'Thisl' should be 'This'.
Thisl will improve performance a lot.