feat: support multiple cwd scenario

[kuitos]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @kuitos, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the package management logic to explicitly handle a project_root parameter. This change enables the system to support scenarios where multiple projects might be managed concurrently or where file system operations need to be scoped to a specific project directory, rather than relying solely on the global current working directory. The core functions for dependency installation, package.json management, and path resolution have been updated to accept and utilize this new project_root context, enhancing the system's flexibility and robustness in multi-project environments.

Highlights

• Multi-CWD Support: Introduced a project_root parameter to core package management functions (install_deps, ensure_package_json, install_package, PackagePaths::new) to explicitly define the context for file operations, enabling support for multiple current working directory scenarios.
• Path Resolution Logic: Modified the PackagePaths::new constructor to intelligently resolve link_target_dir. It now joins relative path_key values with the provided project_root while preserving absolute path_key values, ensuring correct package linking across different project contexts.
• Comprehensive Test Updates: All relevant test cases have been updated to utilize distinct project_root paths, including a new helper function project_root for consistent setup. This ensures the new multi-CWD logic is thoroughly validated, especially for path handling and package installation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for multiple project roots by passing an explicit project_root path to functions that interact with the filesystem. This is a solid improvement that removes reliance on the current working directory. The changes are consistently applied across the package manager logic, and the tests have been updated to reflect the new API, including a new test for absolute path handling.

I have one suggestion to improve performance slightly by avoiding repeated allocations within a loop. Overall, this is a great change.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[kuitos]

/gemini review

[gemini-code-assist]

Code Review

This pull request successfully refactors the package installation logic to support multiple project roots (cwd), which is a significant improvement. The changes are well-structured, passing the project_root through the call chain from install_deps down to PackagePaths::new and install_package. The logic to differentiate between absolute and relative path_key is correct and is accompanied by a new test case. The updates to existing tests to accommodate the new project_root parameter are thorough. I have one suggestion to improve error handling to make the code more robust.