fix(pack): disable ts_transform for foreign_code#2267
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build failure in Turbopack where enabling TypeScript transformation for external modules (e.g., Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary
PR: #2237 为了处理
node_modules中的 alias 给 foreign_code 开启了enable_typescript配置,turbopack 在开启这个配置后处理 node_modules 中的依赖时会去解析对应的tsconfig.json文件(做 typescript transform 用),但实际上很多 npm 包 tsconfig file 中的依赖是devDependencies,这会导致 resolve errror,参考:之前 alias 这个问题的时候,本质上还是从
extensions的角度来处理,这里默认给 foreign_code 的 extensions 打开更多的后缀即可。Test Plan
旧的快照测试不变,新增了
node_modules/tsconfig-mod/tsconfig.json相关的测试 case.