-
Notifications
You must be signed in to change notification settings - Fork 107
fix: invalid wasm runtime export object #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the generated WebAssembly (WASM) import object was malformed due to a missing comma in its string representation. The fix ensures that the WASM runtime can correctly parse and utilize the import object, which is crucial for the proper instantiation and execution of WASM modules within the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a bug that caused invalid JavaScript to be generated for WASM modules with multiple imports. The change correctly adds a comma to separate properties in the generated import object. My review includes a suggestion for a more idiomatic way to construct this comma-separated string in Rust, which would improve code clarity and maintainability.
|
|
||
| wasm_import_object_code.push_str(&format!( | ||
| "\"{module}\": {{ {names} }}", | ||
| "\"{module}\": {{ {names} }},", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change correctly fixes a bug where invalid JavaScript was generated for WASM modules with multiple imports. While adding a trailing comma works and is valid in modern JavaScript, a more idiomatic and robust approach in Rust is to build a list of strings and then use join(", "). This avoids manual comma management and the resulting trailing comma, leading to cleaner and more maintainable code.
As below:
