Skip to content

Conversation

@fireairforce
Copy link
Contributor

Summary

PR: utooland/next.js#73

Test Plan

更新了快照测试

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a parsing issue by adding support for the ~ prefix in Less and Sass import paths. This enhancement ensures that module imports, particularly those referencing packages within node_modules, are correctly resolved. A new snapshot test case has been added to validate this functionality for Less, demonstrating the successful compilation of a stylesheet importing antd/reset.css using the ~ prefix. Additionally, the next.js subproject has been updated.

Highlights

  • Less/Sass ~ Prefix Support: Implements support for parsing the ~ prefix in Less and Sass import statements, which is commonly used for resolving modules from node_modules.
  • New Snapshot Test Case: Introduces a new snapshot test specifically for Less, demonstrating the correct resolution of an @import '~antd/reset.css'; statement.
  • Subproject Update: Updates the next.js subproject to a newer commit (ee0e4f6384c4a22b366d2faded519c4b62750eff).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 增加了一个快照测试,用于验证在 less 导入中对 ~ 前缀的支持。测试用例结构良好。然而,PR 标题同时提到了 lesssass,但目前只添加了 less 的测试。为了确保该功能在 sass 中也能正常工作并防止未来的回归,强烈建议为 sass 也补充相应的快照测试。此外,在测试用的 CSS 文件中发现一个小问题,已在具体评论中指出。

@fireairforce fireairforce force-pushed the less-support-webpack-import branch from f844332 to 94fc3d9 Compare November 11, 2025 05:48
@fireairforce fireairforce merged commit e7914fb into next Nov 11, 2025
17 checks passed
@fireairforce fireairforce deleted the less-support-webpack-import branch November 11, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants