Skip to content

feat(pack): set invalid export checker from error to warning#2361

Closed
fireairforce wants to merge 1 commit intonextfrom
fix-invalid-export-checker
Closed

feat(pack): set invalid export checker from error to warning#2361
fireairforce wants to merge 1 commit intonextfrom
fix-invalid-export-checker

Conversation

@fireairforce
Copy link
Copy Markdown
Member

Summary

for issue: #2323

把这个检查先从 error 调整到 warning 了,参考 webpack 的配置: https://webpack.js.org/configuration/module/#moduleparserjavascriptimportexportspresence

Test Plan

参考快照测试里面的日志输出。

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the build process to treat invalid export declarations as warnings rather than errors. This change aims to improve the developer experience by allowing builds to complete with non-blocking notifications for potential issues, rather than failing outright. It also includes necessary updates to snapshot tests to reflect this change in diagnostic output and an update to the next.js subproject.

Highlights

  • Invalid Export Checker Severity: The severity of the invalid export checker has been downgraded from an error to a warning, aligning with common practices in bundlers like Webpack.
  • Snapshot Test Updates: Snapshot test files related to typescript/interface_export have been updated to reflect the change in severity from error to warning for invalid exports.
  • CSS Snapshot Update: A CSS snapshot test file has been updated to change a color value from #000 to #000000d9.
  • next.js Subproject Update: The next.js subproject has been updated to a newer commit (ea4e1a9d36dd2fcd5839abdcdfa883182e1816f1).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 的核心改动是将无效导出的检查从 error 调整为 warning,此举参考了 Webpack 的相关配置,使行为保持一致。相关的快照测试也已同步更新,正确反映了这一变化。另外,CSS 快照测试中 color 值的变化(从 #000#000000d9)是正确的,它修正了之前未能正确处理颜色透明度的问题,这很可能是由于 next.js 子模块更新带来的一个积极改进。整体而言,本次提交的修改是正确且合理的,没有发现问题。

@xusd320
Copy link
Copy Markdown
Contributor

xusd320 commented Dec 2, 2025

#2360 一起更新了

@xusd320 xusd320 closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants