feat(pack): set invalid export checker from error to warning#2361
feat(pack): set invalid export checker from error to warning#2361fireairforce wants to merge 1 commit intonextfrom
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the build process to treat invalid export declarations as warnings rather than errors. This change aims to improve the developer experience by allowing builds to complete with non-blocking notifications for potential issues, rather than failing outright. It also includes necessary updates to snapshot tests to reflect this change in diagnostic output and an update to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
在 #2360 一起更新了 |
Summary
for issue: #2323
把这个检查先从 error 调整到 warning 了,参考 webpack 的配置: https://webpack.js.org/configuration/module/#moduleparserjavascriptimportexportspresence
Test Plan
参考快照测试里面的日志输出。