-
Notifications
You must be signed in to change notification settings - Fork 108
fix(pack): define value too big to make define not work #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a reported issue (referenced as #2388) by adding a comprehensive snapshot test case. The test is designed to specifically validate the behavior of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new snapshot test case to address an issue where define values, particularly large ones, were not working as expected. However, the generated output for the test case indicates that the define replacement is not being applied to the RoutePathEnum identifier. This suggests that the underlying issue might not be fully resolved, or the define transformation step is not correctly integrated into the bundling process for this module. The test, in its current state, does not verify the intended fix.
...ne/complex/output/crates_pack-tests_tests_snapshot_define_complex_input_index_ts_d888f878.js
Outdated
Show resolved
Hide resolved
7c806a5 to
162ec5e
Compare
162ec5e to
f775c43
Compare
Summary
closes: #2388
上游修复: utooland/next.js#78
Test Plan
添加了一个很大的测试 case