-
Notifications
You must be signed in to change notification settings - Fork 107
perf(wasm): use forked mimalloc and enable full threads of tokio #2398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly boosts WASM performance by integrating a specialized Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces performance improvements by switching to a forked version of mimalloc and configuring the Tokio runtime to utilize all available threads, which is a great enhancement. The dependency changes in Cargo.toml and Cargo.lock are consistent with this goal. The removal of the hardcoded worker thread count in the Tokio runtime is a good improvement. The addition of the less-loader files seems unrelated to the primary performance focus but is handled correctly by excluding them from biome processing. My review includes a couple of suggestions for code cleanup in the new and modified files.
packages/utoo-web/src/webpackLoaders/loaders/lessLoader/utils.js
Outdated
Show resolved
Hide resolved
e55452d to
21da8b9
Compare
cfcee6f to
1b66ad6
Compare
1b66ad6 to
47763d1
Compare
utooland/mimalloc@88e710e
utooland/mimalloc_rust@fed2a96
utooland/next.js#79
It improves performance by
100%dlmallocmimalloc