Skip to content

Conversation

@xusd320
Copy link
Contributor

@xusd320 xusd320 commented Dec 11, 2025

utooland/mimalloc@88e710e
utooland/mimalloc_rust@fed2a96
utooland/next.js#79

It improves performance by 100%

dlmalloc
image

mimalloc
image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly boosts WASM performance by integrating a specialized mimalloc memory allocator and enabling tokio to leverage all available CPU threads. These core changes are reported to double the performance. Additionally, the PR introduces a new Less CSS webpack loader, enhancing the project's front-end build process.

Highlights

  • Memory Allocator Upgrade: The WASM build has been switched to use a custom-forked mimalloc implementation (utooland/mimalloc_rust), replacing the previous rspack-specific version. This change is foundational for memory management optimizations and is expected to significantly boost performance.
  • Enhanced Tokio Threading: The tokio runtime configuration for WASM has been updated to remove the explicit limit of 4 worker threads, allowing it to fully utilize all available threads for improved concurrency and processing power, directly contributing to the reported performance gains.
  • New Less Webpack Loader: A new webpack loader for the Less CSS preprocessor has been introduced, complete with its options and utility functions. This expands the project's styling capabilities and front-end build process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces performance improvements by switching to a forked version of mimalloc and configuring the Tokio runtime to utilize all available threads, which is a great enhancement. The dependency changes in Cargo.toml and Cargo.lock are consistent with this goal. The removal of the hardcoded worker thread count in the Tokio runtime is a good improvement. The addition of the less-loader files seems unrelated to the primary performance focus but is handled correctly by excluding them from biome processing. My review includes a couple of suggestions for code cleanup in the new and modified files.

@xusd320 xusd320 force-pushed the perf/wasm-mimalloc branch 2 times, most recently from cfcee6f to 1b66ad6 Compare December 12, 2025 03:21
@xusd320 xusd320 merged commit 24361d1 into next Dec 12, 2025
17 of 19 checks passed
@xusd320 xusd320 deleted the perf/wasm-mimalloc branch December 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants