Skip to content

Conversation

@fireairforce
Copy link
Contributor

@fireairforce fireairforce commented Jan 16, 2026

Summary

closes: #2477

ref pr: utooland/next.js#98

Test Plan

快照测试刷新了。

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决 Turbopack 打包器在处理异步 chunk 时可能出现的模块重复问题。通过调整模块的打包和加载机制,确保异步加载的模块能够被正确地去重和引用,从而提升打包效率和输出质量。此次更改主要体现在对现有快照测试输出的更新,以验证修复的有效性。

Highlights

  • 异步 Chunk 重复模块修复: 修复了 Turbopack 打包器在处理异步 chunk 时可能包含重复模块的问题,确保打包输出的唯一性。
  • 快照测试更新: 更新了多个快照测试的输出文件,以反映修复后的正确打包结果和模块结构变化。
  • 模块加载逻辑优化: 优化了异步模块的加载和引用逻辑,以消除打包输出中的冗余。
  • Next.js 子项目更新: 更新了 next.js 子项目的引用版本,同步了上游的最新更改。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好!这个 PR 旨在修复异步块中包含重复块的问题。从变更来看,主要是更新了大量的快照测试,这反映了打包器输出结果的变化。我注意到在多个测试用例中,生成包内的模块顺序发生了改变,这通常是打包逻辑变更后的正常现象。

我仔细检查了这些快照,发现了一个关于 stats.json 文件生成的问题,具体请看我的评论。除此之外,这些快照更新看起来与 PR 的目标是一致的。

@fireairforce fireairforce marked this pull request as ready for review January 18, 2026 15:39
@fireairforce fireairforce merged commit 57609fb into next Jan 18, 2026
15 checks passed
@fireairforce fireairforce deleted the fix-chunk-size branch January 18, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Utoopack] splitChunk 拆包优化

2 participants