Remove Copy trait from BuildEvent and PackageTarballInfo #2581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Copytrait was implemented onBuildEvent<'a>andPackageTarballInfo<'a>despite these being event types containing borrowed references. While technically valid (all fields areCopy), this is semantically incorrect—events represent discrete state changes and shouldn't be trivially duplicated.Changes
Copyfrom event types:BuildEvent<'a>andPackageTarballInfo<'a>now derive onlyClonePipelineReceiver::on_eventto explicitly clone the event when forwarding to inner receiverThis follows Rust idioms where
ClonewithoutCopysignals that duplication has semantic weight, appropriate for event types.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.