Skip to content

Conversation

@piiertho
Copy link
Member

@piiertho piiertho commented Dec 8, 2025

This resolves #406

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where parameters were not being applied to one-shot events. The issue was that apply_parameters() always operated on the member variable _event, but one-shot events use a separate local event instance that needs to have parameters applied to it.

Key Changes:

  • Refactored apply_parameters() into two overloaded _apply_parameters() methods - one that accepts a Ref<FmodEvent> parameter and one parameterless version
  • Updated _play() to pass the local event instance to _apply_parameters() so one-shot events receive their parameters correctly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Trodgy
Copy link

Trodgy commented Dec 8, 2025

is there a way for me to compile the branch into a gdextension? the issue that this would fix is empeding progress for me right now and I'm not sure when this will actually be merged and given a new release

actually nvm I got confused the issue I'm having is caused by #403, mb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

play_one_shot() in EventEmitter doesn't apply parameters

4 participants