Fix build errors with Kotlin version compatibility and deprecated APIs #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated APIs - Fix kotlin-stdlib version conflict by downgrading dependencies: - kotlinx-serialization: 1.9.0 → 1.7.3 - kotlinx-datetime: 0.7.1 → 0.6.1 - Add resolution strategy to force kotlin-stdlib 2.1.0 - Remove deprecated outputModuleName from wasmJs configuration in: - jsonBuilderWeb/build.gradle.kts - samples/sharedCompose/build.gradle.kts - samples/routerApp/composeApp/build.gradle.kts - Replace deprecated buildDir with layout.buildDirectory.get().asFile in: - jsonBuilderWeb/build.gradle.kts - samples/routerApp/composeApp/build.gradle.kts - Fix CocoaPods configuration for Firebase sample: - Add source 'https://cdn.cocoapods.org' to Podfile - Add missing FirebaseCoreInternal pod dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build errors related to Kotlin version compatibility and deprecated Gradle APIs. The changes ensure compatibility with Kotlin 2.1.0 by addressing KLIB ABI incompatibility issues and removing deprecated API usage.
- Removed deprecated
moduleNameconfiguration from wasmJs targets - Replaced deprecated
buildDirwithlayout.buildDirectory.get().asFile - Updated CocoaPods configuration with source repository and missing dependency
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| samples/sharedCompose/build.gradle.kts | Removed deprecated moduleName from wasmJs configuration |
| samples/routerApp/composeApp/build.gradle.kts | Removed deprecated moduleName and replaced buildDir with modern API |
| samples/firebaseApp/iosApp/Podfile | Added CocoaPods source repository and missing FirebaseCoreInternal dependency |
| samples/firebaseApp/composeApp/build.gradle.kts | Added explicit project.dependencies.platform() call for Firebase BOM |
| jsonBuilderWeb/build.gradle.kts | Removed deprecated moduleName and replaced buildDir with modern API |
| gradle/libs.versions.toml | Updated library versions for compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Update compileSdk from 35 to 36 across all Android modules to meet the minimum requirement for androidx.activity:activity-compose:1.11.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Upgrade Gradle wrapper from 8.12 to 8.13 - Add compose.materialIconsExtended dependency to routerApp to fix unresolved icons - Update Podfile.lock checksums after Podfile changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves multiple build errors related to Kotlin version compatibility and deprecated Gradle APIs.
Changes
1. Kotlin Version Compatibility
kotlinx-serialization: 1.9.0 → 1.7.3kotlinx-datetime: 0.7.1 → 0.6.1build.gradle.ktsto forcekotlin-stdlib2.1.02. Deprecated API Removals
outputModuleNamefrom wasmJs configurationbuildDirwithlayout.buildDirectory.get().asFile3. CocoaPods Configuration Fix
source 'https://cdn.cocoapods.org'to Firebase sample PodfileFirebaseCoreInternalpod dependencyTesting
🤖 Generated with Claude Code