nohup: restrict nohup.out permissions to 0600 #10032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you please add a test to make sure we don't regress in the future? |
Author
|
I added two tests:
|
Contributor
|
Please run cargo fmt |
|
GNU testsuite comparison: |
aristarhoskal
force-pushed
the
fix_nohup_permissions
branch
from
e315f9c to
87dbd01
Compare
sylvestre
reviewed
Jan 4, 2026
src/uu/nohup/src/nohup.rs
Outdated
| homeout.push(NOHUP_OUT); | ||
| let homeout_str = homeout.to_str().unwrap(); | ||
| match OpenOptions::new().create(true).append(true).open(&homeout) { | ||
| match OpenOptions::new() |
Contributor
There was a problem hiding this comment.
please create a function for OpenOptions::new()
as it is duplicated from line 140
aristarhoskal
force-pushed
the
fix_nohup_permissions
branch
2 times, most recently
from
785202c to
d1e3ffd
Compare
|
GNU testsuite comparison: |
Contributor
|
A test is missing |
aristarhoskal
force-pushed
the
fix_nohup_permissions
branch
from
d1e3ffd to
237b8d5
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10021