fix: handle /dev/full write errors gracefully #10062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoNao89
force-pushed
the
fix/issue-9769-dev-full-panic
branch
from
b378518 to
d0cfa2d
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 5, 2026
Fixes uutils#9769 Changed error.print().unwrap() to let _ = error.print() to prevent panic when writing to /dev/full. Added regression test in test_cat.rs.
naoNao89
force-pushed
the
fix/issue-9769-dev-full-panic
branch
from
d0cfa2d to
9cc2e09
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hehe, i think this very simple fix if correct 😅
just changed
.unwrap()tolet _ =in error.rs. now utilities don't panic when writing to /dev/full, they exit gracefully like GNU coreutils does.one line fix + regression test. affects 20+ utilities.
Fixes #9769