Call libc::utimensat directly rather than using filetimes crate #10063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…touch permissions when updating time to now
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #10063 will improve performance by 3.57%Comparing Summary
Benchmarks breakdown
Footnotes
|
sylvestre
reviewed
Jan 5, 2026
| set_file_times(path, atime, mtime) | ||
| #[cfg(unix)] | ||
| { | ||
| if opts.source == Source::Now |
Contributor
There was a problem hiding this comment.
please add a comment explaining why you are doing this
sylvestre
reviewed
Jan 5, 2026
|
|
||
| #[test] | ||
| #[cfg(target_os = "linux")] | ||
| #[cfg(all(unix, not(target_os = "openbsd")))] |
Contributor
Author
There was a problem hiding this comment.
openbsd doesn't have /dev/full
https://man.openbsd.org/MAKEDEV.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9870 coincidentally works on linux but does not work on platforms where
UTIME_NOWwhich is originally alongdoesn't fit intou32, such as freebsd.It's not possible to use
UTIME_NOWinutimensatwith the filetimes crate on these platforms. I copied the relevant piece of code being called from filetimes so I can calllibc::utimensatdirectly. Providing a nullptr as the times argument as the same effect as bothtv_nsecfields beingUTIME_NOW.For the tests, OpenBSD doesn't have a
/dev/fullbuttouch /dev/nullessentially tests the same permission issue.