numfmt: support non-UTF8 delimiters for locales like GB18030 #10079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 6, 2026
sylvestre
reviewed
Jan 6, 2026
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test corresponds to the numfmt-nonutf8 gnu test and the change is to parse the separator as an OsString so that non-UTF8 delimeters can be used. There is one todo where GNU is only supposed to accept a single character when its non UTF8 but we don't have the capability to determine this yet for locales and this is missing in cut nl and in numfmt, so for now it still will let you but we need to follow up with that in the future. I also added some regression tests.