cp: use FileInformation without dereference for symlink destination check to match GNU behaviour for test/nfs-removal-race #10086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
fix-nfs-removal-race
branch
from
e6af615 to
9ad2ff6
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
fix-nfs-removal-race
branch
2 times, most recently
from
4afa44e to
af2fba8
Compare
ChrisDryden
force-pushed
the
fix-nfs-removal-race
branch
from
af2fba8 to
fdd0b1d
Compare
ChrisDryden
commented
Jan 6, 2026
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
changed the title
sgmarz
pushed a commit
to sgmarz/coreutils
that referenced
this pull request
Jan 7, 2026
…heck to match GNU behaviour for test/nfs-removal-race (uutils#10086) * cp: use lstat for destination check to support LD_PRELOAD tests * fs: fix Windows is_symlink type mismatch and add explanatory comment * cp: use stat for dest existence check to support LD_PRELOAD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing around to see the different GLIBC calls on different versions of GLIBC and what was going on with this test. Turns out that the test doesn't even pass on the original cp on different versions of GLIBC. I was able to make a PR to the main coreutils repository that covers both GLIBC versions and when that in, this should pass the nfs-race GNU test
Update:
The PR was merged coreutils/coreutils@1afe410 here and now it should allow us to use the FileInformation helpers so that we can replicate the types of calls that are made to better match how the file metadata is fetched.