pr: add -T/--omit-pagination option #10107
Merged
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategy I'm taking with fixing all of the issues with the PR utility is to first add all of the missing options, then to focus on fixing how those options are used. Right now we are down to 665 failing tests and 87 of those failures are status code mismatches from invalid options. This makes the failures stay at 665 but the amount of status code mismatches goes down to 48 after this. The logic for omit pagination is added here, but the stripping of the form feeds is not implemented.
There are multiple underlying issues in the PR implementation that I don't think it would be the best idea to try and implement it all at once, I'm hoping after all of the options are recognized and parsed correctly we can start tackling the output matching logic to make more of the tests pass and implement tests that validate the output.