Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Jan 7, 2026

The strategy I'm taking with fixing all of the issues with the PR utility is to first add all of the missing options, then to focus on fixing how those options are used. Right now we are down to 665 failing tests and 87 of those failures are status code mismatches from invalid options. This makes the failures stay at 665 but the amount of status code mismatches goes down to 48 after this. The logic for omit pagination is added here, but the stripping of the form feeds is not implemented.

There are multiple underlying issues in the PR implementation that I don't think it would be the best idea to try and implement it all at once, I'm hoping after all of the options are recognized and parsed correctly we can start tackling the output matching logic to make more of the tests pass and implement tests that validate the output.

@ChrisDryden ChrisDryden marked this pull request as ready for review January 7, 2026 18:40
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/id/smack is no longer failing!
Congrats! The gnu test tests/mkdir/smack-no-root is no longer failing!
Congrats! The gnu test tests/mkdir/smack-root is no longer failing!

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

Merging this PR will improve performance by 3.45%

Summary

⚡ 1 improved benchmark
✅ 139 untouched benchmarks
⏩ 37 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
tsort_input_parsing_heavy[5000] 73.7 ms 71.3 ms +3.45%

Comparing ChrisDryden:pr-omit-pagination (25d5051) with main (20a5c3a)

Open in CodSpeed

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker cakebaker merged commit da664ec into uutils:main Jan 8, 2026
130 of 131 checks passed
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants