Skip to content

Disable tsort_input_parsing_heavy for being too intermittent #10109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylvestre wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable tsort_input_parsing_heavy for being too intermittent #10109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c2219
Disable tsort_input_parsing_heavy for being too intermittent
sylvestre Jan 7, 2026
8ffc854
also ignore generate_input_parsing_heavy
sylvestre Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/uu/tsort/benches/tsort_bench.rs
View file
Open in desktop
Copy link
Contributor

@cakebaker cakebaker Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add two comments about why the functions are disabled. An alternative might be to remove them.

Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ fn generate_wide_dag(num_nodes: usize) -> Vec<u8> {
data
}

/*
/// Generate DAG data for input parsing stress tests
fn generate_input_parsing_heavy(num_edges: usize) -> Vec<u8> {
// Create a scenario with many edges but relatively few unique nodes
Expand All @@ -133,6 +134,7 @@ fn generate_input_parsing_heavy(num_edges: usize) -> Vec<u8> {

data
}
*/

/// Benchmark linear chain graphs of different sizes
/// This tests the performance improvements mentioned in PR #8694
Expand Down Expand Up @@ -184,6 +186,7 @@ fn tsort_wide_dag(bencher: Bencher, num_nodes: usize) {
});
}

/*
/// Benchmark input parsing vs computation by using files with different edge densities
#[divan::bench(args = [5_000])]
fn tsort_input_parsing_heavy(bencher: Bencher, num_edges: usize) {
Expand All @@ -195,6 +198,7 @@ fn tsort_input_parsing_heavy(bencher: Bencher, num_edges: usize) {
black_box(run_util_function(uumain, &[file_path_str]));
});
}
*/

fn main() {
divan::main();
Expand Down
Loading