Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 8, 2026

No description provided.

@oech3 oech3 force-pushed the warn-bad-workaround branch from f5327d3 to 0ad20fe Compare January 8, 2026 04:33
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 8, 2026

Merging this PR will degrade performance by 4.25%

Summary

❌ 1 regressed benchmark
✅ 141 untouched benchmarks
⏩ 37 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
cksum_blake3 218.9 µs 228.6 µs -4.25%

Comparing oech3:warn-bad-workaround (3c821b2) with main (30239e6)

Open in CodSpeed

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review January 8, 2026 06:20
@oech3
Copy link
Contributor Author

oech3 commented Jan 8, 2026

I can't fix cargo-deny. @RenjiSann

@oech3 oech3 closed this Jan 8, 2026
@oech3 oech3 deleted the warn-bad-workaround branch January 8, 2026 15:47
@oech3 oech3 restored the warn-bad-workaround branch January 8, 2026 16:12
@oech3 oech3 reopened this Jan 8, 2026
@oech3
Copy link
Contributor Author

oech3 commented Jan 8, 2026

I'm very sad. But it seems this is best method until clap 5 was released...

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3 oech3 force-pushed the warn-bad-workaround branch from 0ad20fe to 3c821b2 Compare January 9, 2026 08:27
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant