Skip to content

df: improve perfs #10122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 2 commits into from
Jan 9, 2026
Merged

df: improve perfs #10122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c88726
df: fix O(n²) performance in deeply nested directories by checking is…
sylvestre Jan 8, 2026
16b7857
add "sysfs" to the spell-checker ignore
sylvestre Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/uu/df/src/df.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.
// spell-checker:ignore itotal iused iavail ipcent pcent tmpfs squashfs lofs
// spell-checker:ignore itotal iused iavail ipcent pcent tmpfs squashfs lofs sysfs
mod blocks;
mod columns;
mod filesystem;
Expand Down Expand Up @@ -311,7 +311,11 @@ fn get_all_filesystems(opt: &Options) -> UResult<Vec<Filesystem>> {
// but `vmi` is probably not very long in practice.
if is_included(&mi, opt) && is_best(&mounts, &mi) {
let dev_path: &Path = Path::new(&mi.dev_name);
if dev_path.is_symlink() {
// Only check is_symlink() for absolute paths. For non-absolute paths
// like "tmpfs", "sysfs", etc., is_symlink() would resolve relative to
// the current working directory, which is extremely slow in deeply
// nested directories (O(n) syscalls where n is the directory depth).
if dev_path.is_absolute() && dev_path.is_symlink() {
if let Ok(canonicalized_symlink) = uucore::fs::canonicalize(
dev_path,
uucore::fs::MissingHandling::Existing,
Expand Down
Loading